aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
Diffstat
-rw-r--r--arch/riscv64/config.h2
-rw-r--r--arch/riscv64/kernel/power.c2
-rw-r--r--arch/riscv64/kernel/proc.c4
-rw-r--r--arch/riscv64/kernel/vmem.c2
-rw-r--r--common/dmem.c2
-rw-r--r--common/elf.c10
-rw-r--r--common/mem_regions.c4
-rw-r--r--common/proc.c2
-rw-r--r--common/tcb.c12
-rw-r--r--common/timer.c2
-rw-r--r--common/uapi/ipc.c2
-rw-r--r--common/uapi/mem.c2
-rw-r--r--common/uapi/proc.c8
-rw-r--r--common/vmem.c4
-rw-r--r--include/apos/assert.h2
-rw-r--r--include/apos/tcb.h4
-rw-r--r--include/apos/timer.h2
-rw-r--r--include/arch/cpu.h2
18 files changed, 34 insertions, 34 deletions
diff --git a/arch/riscv64/config.h b/arch/riscv64/config.h
index ba7fafe..7be4bb3 100644
--- a/arch/riscv64/config.h
+++ b/arch/riscv64/config.h
@@ -75,7 +75,7 @@
#else
/* 32bit */
-/* \todo: figure this stuff out */
+/** \todo figure this stuff out */
#define VM_DMAP (0x000000000)
#define VM_KERN (VM_DMAP + SZ_256K)
#define ROOT_PTE (0UL)
diff --git a/arch/riscv64/kernel/power.c b/arch/riscv64/kernel/power.c
index 160cf25..b79b7ba 100644
--- a/arch/riscv64/kernel/power.c
+++ b/arch/riscv64/kernel/power.c
@@ -28,7 +28,7 @@
stat_t poweroff(enum poweroff_type type)
{
- /* \todo: this only shuts down the cpu itself, but may leave the SOC
+ /** \todo this only shuts down the cpu itself, but may leave the SOC
* active. Should read from fdt poweroff and syscon-poweroff etc */
switch (type) {
case SHUTDOWN:
diff --git a/arch/riscv64/kernel/proc.c b/arch/riscv64/kernel/proc.c
index b3a1ca7..09d694f 100644
--- a/arch/riscv64/kernel/proc.c
+++ b/arch/riscv64/kernel/proc.c
@@ -8,7 +8,7 @@
#include "regs.h"
#include "csr.h"
-/* \todo: actually map fdt into the target address space */
+/** \todo actually map fdt into the target address space */
stat_t run_init(struct tcb *t, void *fdt)
{
csr_write(CSR_SSCRATCH, t);
@@ -36,7 +36,7 @@ stat_t set_ipc(struct tcb *t, id_t pid, id_t tid)
stat_t set_thread(struct tcb *t, vm_t stack)
{
/* get location of registers in memory */
- /* \todo: check alignment, should be fine but just to be sure */
+ /** \todo check alignment, should be fine but just to be sure */
struct riscv_regs *r = (struct riscv_regs *)(--t);
/* insert important values into register slots */
diff --git a/arch/riscv64/kernel/vmem.c b/arch/riscv64/kernel/vmem.c
index deafb6a..6d0b60c 100644
--- a/arch/riscv64/kernel/vmem.c
+++ b/arch/riscv64/kernel/vmem.c
@@ -223,7 +223,7 @@ vm_t setup_kernel_io(struct vmem *b, vm_t paddr)
stat_t clone_uvmem(struct vmem *r, struct vmem *b)
{
- /* \todo: error checking? */
+ /** \todo error checking? */
for (size_t i = 0; i <= CSTACK_PAGE; ++i)
b->leaf[i] = r->leaf[i];
diff --git a/common/dmem.c b/common/dmem.c
index 3faf4b3..3a50768 100644
--- a/common/dmem.c
+++ b/common/dmem.c
@@ -39,7 +39,7 @@ static stat_t dev_alloc_wrapper(struct vmem *b, pm_t *offset, vm_t vaddr,
void *data)
{
stat_t *status = (stat_t *)data;
- /* \todo: remember to do something with this status info */
+ /** \todo remember to do something with this status info */
*status = map_vpage(b, *offset, vaddr, flags, order);
*offset += order_size(order);
return OK;
diff --git a/common/elf.c b/common/elf.c
index f947b60..97f164d 100644
--- a/common/elf.c
+++ b/common/elf.c
@@ -30,13 +30,13 @@ static void __map_exec(struct tcb *t, vm_t bin, uint8_t ei_c, vm_t phstart,
{
hard_assert(t && is_proc(t), RETURN_VOID);
- /* \todo: take alignment into consideration? */
- /* \todo: take overlapping memory regions into account, probably mostly
+ /** \todo take alignment into consideration? */
+ /** \todo take overlapping memory regions into account, probably mostly
* by keeping track of previously allocated area and seeing if the
* segment fits into it */
- /* \todo: check if p_memsz is larger than p_filesz, the segment should be
+ /** \todo check if p_memsz is larger than p_filesz, the segment should be
* filled with zeroes. */
- /* \todo: in general, make this a low more clean. */
+ /** \todo in general, make this a low more clean. */
vm_t runner = phstart;
vmflags_t default_flags = VM_V | VM_R | VM_W | VM_X | VM_U;
for (size_t i = 0; i < phnum; ++i, runner += phsize) {
@@ -74,7 +74,7 @@ static void __map_exec(struct tcb *t, vm_t bin, uint8_t ei_c, vm_t phstart,
static vm_t __map_dyn(struct tcb *t, vm_t bin, uint8_t ei_c, vm_t phstart,
size_t phnum, size_t phsize)
{
- /* \todo: this path should only be taken when no PT_INTERP is defined, as
+ /** \todo this path should only be taken when no PT_INTERP is defined, as
* making sure ld is loaded should be done in userspace. Maybe a bit
* hacky, I know.*/
}
diff --git a/common/mem_regions.c b/common/mem_regions.c
index 7547ab4..11a167b 100644
--- a/common/mem_regions.c
+++ b/common/mem_regions.c
@@ -140,7 +140,7 @@ stat_t destroy_region(struct mem_region_root *r)
{
__destroy_region(sp_root(&r->free_regions));
__destroy_region(sp_root(&r->used_regions));
- /* \todo: error checking? */
+ /** \todo error checking? */
return OK;
}
@@ -178,7 +178,7 @@ static struct mem_region *__create_region(vm_t start, vm_t end,
return m;
}
-/* \todo: should probably check if this actually works :D seems to do, but that's
+/** \todo should probably check if this actually works :D seems to do, but that's
* just from really quick checking */
static size_t po_align(size_t s)
{
diff --git a/common/proc.c b/common/proc.c
index a660d68..9d74a86 100644
--- a/common/proc.c
+++ b/common/proc.c
@@ -27,7 +27,7 @@ stat_t init_proc(void *fdt)
{
init_tcbs();
- /* \todo: cleanup or something */
+ /** \todo cleanup or something */
struct tcb *t = create_proc(NULL);
if (!t)
return ERR_OOMEM;
diff --git a/common/tcb.c b/common/tcb.c
index a682b07..3f644c1 100644
--- a/common/tcb.c
+++ b/common/tcb.c
@@ -42,7 +42,7 @@ void destroy_tcbs()
static id_t __alloc_tid(struct tcb *t)
{
- /* \todo: this would need some locking or something... */
+ /** \todo this would need some locking or something... */
for (size_t i = start_tid; i < num_tids; ++i) {
if (tcbs[i])
continue;
@@ -55,7 +55,7 @@ static id_t __alloc_tid(struct tcb *t)
return ERR_NF;
}
-/* \todo: add error checking */
+/** \todo add error checking */
static vm_t __setup_rpc_stack(struct tcb *t, size_t bytes)
{
pm_t offset = 0;
@@ -90,7 +90,7 @@ stat_t alloc_stacks(struct tcb *t)
if (!__setup_rpc_stack(p, __call_stack_size))
return ERR_OOMEM;
- /* \todo: this only allows for a global stack size, what if a user wants
+ /** \todo this only allows for a global stack size, what if a user wants
* per thread stack sizes? */
t->thread_stack_top = t->thread_stack + __thread_stack_size;
return OK;
@@ -103,7 +103,7 @@ struct tcb *create_thread(struct tcb *p)
vm_t bottom = alloc_page(MM_O0, 0);
/* move tcb to top of kernel stack, keeping alignment in check
* (hopefully) */
- /* \todo: check alignment */
+ /** \todo check alignment */
struct tcb *t = (struct tcb *)align_down(
bottom + order_size(MM_O0) - sizeof(struct tcb), sizeof(long));
memset(t, 0, sizeof(struct tcb));
@@ -131,7 +131,7 @@ struct tcb *create_thread(struct tcb *p)
static stat_t __clone_proc(struct tcb *p, struct tcb *n)
{
- /* \todo: clone memory regions, and mark them MR_COW, as well as copy
+ /** \todo clone memory regions, and mark them MR_COW, as well as copy
* bm_branch tree but with VM_W off, also at some point write COW
* handler */
return OK;
@@ -161,7 +161,7 @@ static stat_t __destroy_thread_data(struct tcb *t)
vm_t bottom = align_down((vm_t)t, order_size(MM_O0));
free_page(MM_O0, (pm_t)bottom);
- /* \todo: free stacks */
+ /** \todo free stacks */
return OK;
}
diff --git a/common/timer.c b/common/timer.c
index 73b9125..f008851 100644
--- a/common/timer.c
+++ b/common/timer.c
@@ -156,5 +156,5 @@ void update_timers()
struct timer *t = newest_timer();
remove_timer(t);
- /* \todo: handle timer thread ID */
+ /** \todo handle timer thread ID */
}
diff --git a/common/uapi/ipc.c b/common/uapi/ipc.c
index 0d79a92..c163c93 100644
--- a/common/uapi/ipc.c
+++ b/common/uapi/ipc.c
@@ -19,7 +19,7 @@ SYSCALL_DEFINE1(ipc_server)(sys_arg_t callback)
SYSCALL_DEFINE3(ipc_req)(sys_arg_t pid, sys_arg_t d0, sys_arg_t d1)
{
struct tcb *r = get_tcb(pid);
- /* \todo: something like jump_to_callback(t) */
+ /** \todo something like jump_to_callback(t) */
/* remember difference between ipc_req and ipc_fwd! */
return (struct sys_ret){ d0, d1 };
}
diff --git a/common/uapi/mem.c b/common/uapi/mem.c
index cc2818d..45480a9 100644
--- a/common/uapi/mem.c
+++ b/common/uapi/mem.c
@@ -48,7 +48,7 @@ SYSCALL_DEFINE3(req_pmem)(sys_arg_t paddr, sys_arg_t size, sys_arg_t flags)
SYSCALL_DEFINE2(req_sharedmem)(sys_arg_t size, sys_arg_t flags)
{
- /* \todo: check that requester is server */
+ /** \todo check that requester is server */
struct tcb *t = cur_proc();
vm_t start = 0;
if ((start = alloc_shared_uvmem(t, size, flags)))
diff --git a/common/uapi/proc.c b/common/uapi/proc.c
index 604b862..2c1fe77 100644
--- a/common/uapi/proc.c
+++ b/common/uapi/proc.c
@@ -28,7 +28,7 @@ SYSCALL_DEFINE0(fork)(){
}
SYSCALL_DEFINE2(exec)(sys_arg_t bin, sys_arg_t interp){
- /* \todo: execute new process, probably with more sensible argc passing */
+ /** \todo execute new process, probably with more sensible argc passing */
struct tcb *r = cur_tcb();
/* mark binary to be kept */
@@ -58,13 +58,13 @@ SYSCALL_DEFINE2(exec)(sys_arg_t bin, sys_arg_t interp){
}
SYSCALL_DEFINE2(signal)(sys_arg_t tid, sys_arg_t signal){
- /* \todo: signals? */
+ /** \todo signals? */
return (struct sys_ret){ OK, 0 };
}
SYSCALL_DEFINE1(swap)(sys_arg_t tid){
- /* \todo: switch to process */
- /* \todo: should switch return the registers of the new thread that would
+ /** \todo switch to process */
+ /** \todo should switch return the registers of the new thread that would
* be used for message passing? */
return (struct sys_ret){ OK, 0 };
}
diff --git a/common/vmem.c b/common/vmem.c
index 66c3d53..f446b65 100644
--- a/common/vmem.c
+++ b/common/vmem.c
@@ -57,7 +57,7 @@ vm_t alloc_uvmem(struct tcb *t, size_t size, vmflags_t flags)
stat_t status = OK;
const vm_t v = alloc_region(&t->sp_r, size, &size, flags);
const vm_t w = map_allocd_region(t->proc.vmem, v, size, flags, &status);
- /* \todo: this could be changed so that each thread allocated the memory
+ /** \todo this could be changed so that each thread allocated the memory
* region for itself to start with, and only when someone tries to
* access it from some other thread, is it actually cloned. Would likely
* need some major reworkings, so this is good enough for now. */
@@ -122,7 +122,7 @@ vm_t ref_shared_uvmem(struct tcb *t1, struct tcb *t2, vm_t va, vmflags_t flags)
return v;
}
-/* \todo: assume tcb is root tcb? */
+/** \todo assume tcb is root tcb? */
stat_t free_uvmem(struct tcb *t, vm_t va)
{
struct mem_region *m = find_used_region(&t->sp_r, va);
diff --git a/include/apos/assert.h b/include/apos/assert.h
index a6ae3c8..a12f7cc 100644
--- a/include/apos/assert.h
+++ b/include/apos/assert.h
@@ -18,7 +18,7 @@
#include <apos/debug.h>
#include <apos/utils.h>
-/* \todo: should this exit or do something explosive like that? */
+/** \todo should this exit or do something explosive like that? */
#if !defined(DNDEBUG)
/**
diff --git a/include/apos/tcb.h b/include/apos/tcb.h
index 83fbffa..18cf3ad 100644
--- a/include/apos/tcb.h
+++ b/include/apos/tcb.h
@@ -97,7 +97,7 @@ struct tcb {
/** Thread ID. */
id_t tid;
- /* \todo: implement cpu_id to hardware cpu ID translation, first in
+ /** \todo implement cpu_id to hardware cpu ID translation, first in
* riscv. */
/** Cpu currently executing this thread. */
id_t cpu_id;
@@ -111,7 +111,7 @@ struct tcb {
/** Address of this thread's stack top. */
vm_t thread_stack_top;
- /* \todo: Check if each thread should be allowed more than just one
+ /** \todo Check if each thread should be allowed more than just one
* region of thread local storage. */
/** Possible thread local storage. */
vm_t thread_storage;
diff --git a/include/apos/timer.h b/include/apos/timer.h
index 98d9f36..de6141e 100644
--- a/include/apos/timer.h
+++ b/include/apos/timer.h
@@ -126,7 +126,7 @@ static inline ticks_t msecs_to_ticks(tunit_t msecs)
*/
static inline ticks_t secs_to_ticks(tunit_t secs)
{
- /* \todo: likely not a problem on 64bit systems, not sure how to handle situation on
+ /** \todo likely not a problem on 64bit systems, not sure how to handle situation on
* 32bit */
return msecs_to_ticks(secs * 1000);
}
diff --git a/include/arch/cpu.h b/include/arch/cpu.h
index e63b90a..8913b85 100644
--- a/include/arch/cpu.h
+++ b/include/arch/cpu.h
@@ -24,6 +24,6 @@
*/
id_t cpu_id();
-/* \todo: add more cpu handling functions */
+/** \todo add more cpu handling functions */
#endif /* APOS_CPU_H */
generated by cgit v1.3 (git 2.53.0) at 2026-08-27 02:06:05 +0000