diff options
| -rw-r--r-- | common/uapi/dispatch.c | 1 | ||||
| -rw-r--r-- | common/uapi/ipc.c | 15 | ||||
| -rw-r--r-- | include/apos/uapi.h | 6 |
3 files changed, 13 insertions, 9 deletions
diff --git a/common/uapi/dispatch.c b/common/uapi/dispatch.c index 6d70cd4..f2a12d6 100644 --- a/common/uapi/dispatch.c +++ b/common/uapi/dispatch.c @@ -36,6 +36,7 @@ static const sys_t syscall_table[] = { [SYS_IPC_REQ] = sys_ipc_req, [SYS_IPC_FWD] = sys_ipc_fwd, [SYS_IPC_RESP] = sys_ipc_resp, + [SYS_IPC_NOTIFY] = sys_ipc_notify, /* proc */ [SYS_CREATE] = sys_create, diff --git a/common/uapi/ipc.c b/common/uapi/ipc.c index fa0376a..141b494 100644 --- a/common/uapi/ipc.c +++ b/common/uapi/ipc.c @@ -84,13 +84,16 @@ SYSCALL_DEFINE4(ipc_resp)(sys_arg_t d0, sys_arg_t d1, sys_arg_t d2, * * @param tid Thread ID to notify. * @param swap Whether to swap immediately if possible. - * @param a0 Argument 0. - * @param a1 Argument 1. * @return \ref OK and 0. */ -SYSCALL_DEFINE4(ipc_notify)(sys_arg_t tid, sys_arg_t swap, - sys_arg_t a0, sys_arg_t a1){ +SYSCALL_DEFINE2(ipc_notify)(sys_arg_t tid, sys_arg_t swap){ /** \todo masquerade as kernel call, set from to 0 and set us as - * notify type, with arguments a0 and a1 as user-configurable data. */ - return (struct sys_ret){ OK, 0, 0 /* type */, 0 /* from */, a0, a1 }; + * notify type, no arguments as that would require too much state + * handling for my liking. Instead, a server and a client have to agree + * on some rpc API, and ipc_notify is just used to asynchronously inform + * the client that it should check the status of its async operations. + * Arguably slower than directly telling the client which operation was + * finished, but this would require the kernel to keep track of a notify + * stack. While not impossible, probably too complex. */ + return (struct sys_ret){ OK, 0, 0 /* type */, 0 /* from */, 0, 0 }; } diff --git a/include/apos/uapi.h b/include/apos/uapi.h index 8a3deea..cca728b 100644 --- a/include/apos/uapi.h +++ b/include/apos/uapi.h @@ -480,12 +480,12 @@ SYSCALL_DECLARE4(ipc_resp, d0, d1, d2, d3); * * @param tid Thread ID to notify. * @param swap Whether to immediately swap. - * @param a0 Argument 0. - * @param a1 Argument 1. + * @param c Unused. + * @param d Unused. * @param e Unused. * @return \ref OK and 0. */ -SYSCALL_DECLARE4(notify, tid, swap, a0, a1); +SYSCALL_DECLARE2(ipc_notify, tid, swap); /** @} */ /** @name Process handling syscalls. */ |