aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKimplul <kimi.h.kuparinen@gmail.com>2023-06-04 23:35:26 +0300
committerKimplul <kimi.h.kuparinen@gmail.com>2023-06-04 23:35:26 +0300
commitabb11558ee2a2943023f2e9727976a8adace3bc8 (patch)
tree9303176b749d4ba9db92980c93c510c63684ffd1
parent3b8990f17c50e946bc1b9bca5997a25d69d0757c (diff)
downloadkmi-abb11558ee2a2943023f2e9727976a8adace3bc8.tar.gz
kmi-abb11558ee2a2943023f2e9727976a8adace3bc8.zip
clarify a few things
-rw-r--r--common/pmem.c3
-rw-r--r--docs/visionfive2.md7
2 files changed, 6 insertions, 4 deletions
diff --git a/common/pmem.c b/common/pmem.c
index 0fa647f..2a8393c 100644
--- a/common/pmem.c
+++ b/common/pmem.c
@@ -647,7 +647,8 @@ void init_pmem(void *fdt)
info("found fdt at [%lx - %lx]\n", fdt_base, fdt_top);
/* find probably most suitable contiguous region of ram for our physical
- * ram map */
+ * ram map */
+ /** @todo this could be better? */
pm_t pmap_base = align_up(MAX(initrd_top, fdt_top), sizeof(int));
info("choosing to place pmem map at %lx\n", pmap_base);
diff --git a/docs/visionfive2.md b/docs/visionfive2.md
index 51067f1..0ac905e 100644
--- a/docs/visionfive2.md
+++ b/docs/visionfive2.md
@@ -38,14 +38,15 @@ sync
With the SD card ready to go, reset the device and manually run these commands:
-1. `fdt move 0xcce379d0 ${fdt_addr_r}`
+1. `fdt move ${fdtaddr} ${fdt_addr_r}`
2. `load mmc 1:3 0x47000000 kmi.bin`
3. `load mmc 1:3 0x48000000 initrd`
4. `fdt chosen 0x48000000 0x48001000`
5. `go 0x47000000 ${fdt_addr_r}`
-These commands are pretty hard coded and might not work in the future, in which
-case I should come and update them.
+These commands are pretty hard coded and might not work in the future. At least
+currently `${fdt_addr_r}` is `0x46000000`, so you can probably see where the
+other addresses come from.
Other things to note: