aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorguangqing.chen <guangqing.chen@weride.ai>2022-07-25 18:13:26 +0800
committerguangqing.chen <guangqing.chen@weride.ai>2022-07-25 18:13:26 +0800
commit95680ede70a6c4d292f469b630e3c986620fd16a (patch)
tree7df8e49d058d91377cc97a2e41d41ba7fcb987d2
parent162a1f666c71eb5584ed6dae26b957f9405d33bc (diff)
downloadhid-tmff2-95680ede70a6c4d292f469b630e3c986620fd16a.tar.gz
hid-tmff2-95680ede70a6c4d292f469b630e3c986620fd16a.zip
fix state->old may be updated incorrectly
-rw-r--r--hid-tmff2.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/hid-tmff2.c b/hid-tmff2.c
index 12e8e25..24b663e 100644
--- a/hid-tmff2.c
+++ b/hid-tmff2.c
@@ -388,7 +388,7 @@ static int tmff2_upload(struct input_dev *dev,
state->effect = *effect;
if (old) {
- if (test_bit(FF_EFFECT_QUEUE_UPDATE, &state->flags))
+ if (!test_bit(FF_EFFECT_QUEUE_UPDATE, &state->flags))
state->old = *old;
__set_bit(FF_EFFECT_QUEUE_UPDATE, &state->flags);