add todo about minimizing mmap syscalls

2 files changed, 6 insertions, 5 deletions

diff --git a/TODO b/TODO
index b4cf973..e4c54a4 100644
--- a/TODO
+++ b/TODO
@@ -3,8 +3,5 @@ systems
 + (MAYBE) Check that there aren't duplicate destinations in operand list?
 + Darn, the return type doesn't really work with 32bit systems, should fix that
 somehow
-+ Internally we currently expect all values to be doubles, but apparently
-lightening doesn't automatically convert between the types when moving
-parameters. Either we add in float operations and make sure the user knows which
-type is being used when, or we add some filter that rewrites the floats to
-doubles?
++ Try to minimize mmap system calls, they seem to be a significant bottleneck
+for compiling multiple small functions (like in jit-comparison)
diff --git a/src/compile/compile.c b/src/compile/compile.c
index 804a29f..2d1ec5f 100644
--- a/src/compile/compile.c
+++ b/src/compile/compile.c
@@ -2064,6 +2064,10 @@ bool ejit_compile(struct ejit_func *f, bool use_64)
 	if (!init_jit())
 		return false;
 
+	/* the main overhead of compilation seems to be the syscall to mmap a
+	 * new arena, I might look into allocating a big buffer at once and
+	 * caching it to be reused later, might allow us to compile many small
+	 * functions faster */
 	jit_state_t *j = jit_new_state(NULL, NULL);
 	assert(j);