From da8eeb7695a4803d1d45c8c26c05a51fb1ba1e55 Mon Sep 17 00:00:00 2001
From: Kimplul <kimi.h.kuparinen@gmail.com>
Date: Thu, 9 Jun 2022 23:50:14 +0300
Subject: continue documentation

---
 common/uapi/conf.c     | 7 ++++++-
 common/uapi/dispatch.c | 3 ++-
 common/uapi/ipc.c      | 2 +-
 common/uapi/mem.c      | 6 ++++--
 common/uapi/proc.c     | 8 ++++----
 5 files changed, 17 insertions(+), 9 deletions(-)

(limited to 'common/uapi')

diff --git a/common/uapi/conf.c b/common/uapi/conf.c
index 86846b2..26eb9cc 100644
--- a/common/uapi/conf.c
+++ b/common/uapi/conf.c
@@ -12,7 +12,12 @@
 size_t __thread_stack_size = SZ_2M;
 size_t __call_stack_size = SZ_2M;
 
-SYSCALL_DEFINE2(conf)(sys_arg_t param, sys_arg_t val)
+SYSCALL_DEFINE1(conf_get)(sys_arg_t param)
+{
+	return (struct sys_ret){ OK, 0 };
+}
+
+SYSCALL_DEFINE2(conf_set)(sys_arg_t param, sys_arg_t val)
 {
 	UNUSED(param);
 	UNUSED(val);
diff --git a/common/uapi/dispatch.c b/common/uapi/dispatch.c
index df211d5..35c39c9 100644
--- a/common/uapi/dispatch.c
+++ b/common/uapi/dispatch.c
@@ -35,7 +35,8 @@ static const sys_t syscall_table[] = {
 	[SYS_SWAP] = sys_swap,
 
 	/* conf */
-	[SYS_CONF] = sys_conf,
+	[SYS_CONF_SET] = sys_conf_set,
+	[SYS_CONF_GET] = sys_conf_get,
 	[SYS_POWEROFF] = sys_poweroff,
 };
 
diff --git a/common/uapi/ipc.c b/common/uapi/ipc.c
index 4327c90..0d79a92 100644
--- a/common/uapi/ipc.c
+++ b/common/uapi/ipc.c
@@ -19,7 +19,7 @@ SYSCALL_DEFINE1(ipc_server)(sys_arg_t callback)
 SYSCALL_DEFINE3(ipc_req)(sys_arg_t pid, sys_arg_t d0, sys_arg_t d1)
 {
 	struct tcb *r = get_tcb(pid);
-	/* TODO: something like jump_to_callback(t) */
+	/* \todo: something like jump_to_callback(t) */
 	/* remember difference between ipc_req and ipc_fwd! */
 	return (struct sys_ret){ d0, d1 };
 }
diff --git a/common/uapi/mem.c b/common/uapi/mem.c
index 9d631ae..cc2818d 100644
--- a/common/uapi/mem.c
+++ b/common/uapi/mem.c
@@ -18,7 +18,7 @@ SYSCALL_DEFINE2(req_mem)(sys_arg_t size, sys_arg_t flags)
 SYSCALL_DEFINE3(req_fixmem)(sys_arg_t start, sys_arg_t size, sys_arg_t flags)
 {
 	struct tcb *r = cur_proc();
-	/* should probably check if the allocation succeeded...? TODO */
+	/* should probably check if the allocation succeeded...? \todo */
 	return (struct sys_ret){ OK, alloc_fixed_uvmem(r, start, size, flags) };
 }
 
@@ -48,7 +48,7 @@ SYSCALL_DEFINE3(req_pmem)(sys_arg_t paddr, sys_arg_t size, sys_arg_t flags)
 
 SYSCALL_DEFINE2(req_sharedmem)(sys_arg_t size, sys_arg_t flags)
 {
-	/* TODO: check that requester is server */
+	/* \todo: check that requester is server */
 	struct tcb *t = cur_proc();
 	vm_t start = 0;
 	if ((start = alloc_shared_uvmem(t, size, flags)))
@@ -69,3 +69,5 @@ SYSCALL_DEFINE3(ref_sharedmem)(sys_arg_t tid, sys_arg_t va, sys_arg_t flags)
 
 	return (struct sys_ret){ OK, start };
 }
+
+/** \todo add some way to specify who gets to access the shared memory? */
diff --git a/common/uapi/proc.c b/common/uapi/proc.c
index f8ceaa5..604b862 100644
--- a/common/uapi/proc.c
+++ b/common/uapi/proc.c
@@ -28,7 +28,7 @@ SYSCALL_DEFINE0(fork)(){
 }
 
 SYSCALL_DEFINE2(exec)(sys_arg_t bin, sys_arg_t interp){
-	/* TODO: execute new process, probably with more sensible argc passing */
+	/* \todo: execute new process, probably with more sensible argc passing */
 	struct tcb *r = cur_tcb();
 
 	/* mark binary to be kept */
@@ -58,13 +58,13 @@ SYSCALL_DEFINE2(exec)(sys_arg_t bin, sys_arg_t interp){
 }
 
 SYSCALL_DEFINE2(signal)(sys_arg_t tid, sys_arg_t signal){
-	/* TODO: signals? */
+	/* \todo: signals? */
 	return (struct sys_ret){ OK, 0 };
 }
 
 SYSCALL_DEFINE1(swap)(sys_arg_t tid){
-	/* TODO: switch to process */
-	/* TODO: should switch return the registers of the new thread that would
+	/* \todo: switch to process */
+	/* \todo: should switch return the registers of the new thread that would
 	 * be used for message passing? */
 	return (struct sys_ret){ OK, 0 };
 }
-- 
cgit v1.3