diff options
| author | Dario Pagani <dariopag45@gmail.com> | 2021-01-10 14:51:34 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-01-10 14:51:34 +0100 |
| commit | af079a73b61a61d8975b29b329c934371df6831e (patch) | |
| tree | 5b7857a5208baa93e584988217a4d45c3a6f3847 | |
| parent | 7d10d3ee6a7c8722bac60775d66be6cb8b38b9dd (diff) | |
| parent | 742420ee045c97a851ab580f01e98a79da235d65 (diff) | |
| download | hid-tminit-af079a73b61a61d8975b29b329c934371df6831e.tar.gz hid-tminit-af079a73b61a61d8975b29b329c934371df6831e.zip | |
Merge pull request #4 from Peterkmoss/master
* Using `kfree` instead of `kzfree` or `kfree_sensitive`
There is no sensitive information in the driver, so using `kfree` should
be fine. See https://github.com/scarburato/t150_driver/pull/11 for more
information on the discussion.
| -rw-r--r-- | hid-tminit.c | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/hid-tminit.c b/hid-tminit.c index 1538bab..f7c7814 100644 --- a/hid-tminit.c +++ b/hid-tminit.c @@ -54,7 +54,7 @@ static void tminit_interrupts(struct hid_device *hdev){ } } - kzfree(send_buf); + kfree(send_buf); } static void tminit_change_handler(struct urb *urb) @@ -135,10 +135,10 @@ static void tminit_remove(struct hid_device *hdev) usb_kill_urb(tm_wheel->urb); - kzfree(tm_wheel->response); - kzfree(tm_wheel->model_request); + kfree(tm_wheel->response); + kfree(tm_wheel->model_request); usb_free_urb(tm_wheel->urb); - kzfree(tm_wheel); + kfree(tm_wheel); hid_hw_stop(hdev); } @@ -227,10 +227,10 @@ static int tminit_probe(struct hid_device *hdev, const struct hid_device_id *id) return ret; -error5: kzfree(tm_wheel->response); -error4: kzfree(tm_wheel->model_request); +error5: kfree(tm_wheel->response); +error4: kfree(tm_wheel->model_request); error3: usb_free_urb(tm_wheel->urb); -error2: kzfree(tm_wheel); +error2: kfree(tm_wheel); error1: hid_hw_stop(hdev); error0: return ret; |