From c26573d77369c042dc2b9a881a7f2ff88ddc0dd9 Mon Sep 17 00:00:00 2001 From: Kimplul Date: Sun, 4 Jan 2026 21:49:58 +0200 Subject: use on_hid_hw_open instead of input_dev->open + Seems some applications can mess with input_dev->open, still unclear how but on_hid_hw_open seems to be a bit more reliable so use it for now at least --- src/tmt300rs/hid-tmt300rs.c | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) (limited to 'src/tmt300rs') diff --git a/src/tmt300rs/hid-tmt300rs.c b/src/tmt300rs/hid-tmt300rs.c index 00eecee..689466f 100644 --- a/src/tmt300rs/hid-tmt300rs.c +++ b/src/tmt300rs/hid-tmt300rs.c @@ -1287,31 +1287,26 @@ static int t300rs_send_close(struct t300rs_device_entry *t300rs) return t300rs_send_int(t300rs); } -int t300rs_open(void *data, int open_mode) +void t300rs_open(void *data, int open_mode) { struct t300rs_device_entry *t300rs = data; if (!t300rs) - return -ENODEV; + return; if (open_mode && t300rs_send_open(t300rs)) hid_warn(t300rs->hdev, "failed sending open command\n"); - - return t300rs->open(t300rs->input_dev); } -int t300rs_close(void *data, int open_mode) +void t300rs_close(void *data, int open_mode) { struct t300rs_device_entry *t300rs = data; int ret = 0; if (!t300rs) - return -ENODEV; + return; if (open_mode && (ret = t300rs_send_close(t300rs))) hid_warn(t300rs->hdev, "failed sending close command\n"); - - t300rs->close(t300rs->input_dev); - return ret; } static int t300rs_check_firmware(struct t300rs_device_entry *t300rs) @@ -1469,9 +1464,6 @@ static int t300rs_wheel_init(struct tmff2_device_entry *tmff2, int open_mode) t300rs->report = list_entry(report_list->next, struct hid_report, list); t300rs->ff_field = t300rs->report->field[0]; - t300rs->open = t300rs->input_dev->open; - t300rs->close = t300rs->input_dev->close; - /* TODO: PS4 advanced mode? */ alt_mode = (t300rs->mode = (t300rs->hdev->product == TMT300RS_PS3_ADV_ID)); if ((t300rs->attachment = t300rs_get_attachment(t300rs)) < 0) -- cgit v1.3