From c7171a1fe795911a925f47af15352deb6609b001 Mon Sep 17 00:00:00 2001 From: Kimplul Date: Wed, 8 Jul 2020 13:18:01 +0300 Subject: small changes, nothing on value (I assume) --- force-effects.txt | 4 ++-- hid-tmff2.c | 6 ++++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/force-effects.txt b/force-effects.txt index e8fe6f1..6c205f7 100644 --- a/force-effects.txt +++ b/force-effects.txt @@ -98,9 +98,9 @@ FF_RAMP: 60 00 - standard header 01 - ID 6b - new ramp effect - f6 7f - difference *** + f6 7f - difference *** fe ff - level? *** (level = (if end_level > start_level, end_level, else - start_level) - difference?) + start_level) - difference?) (signed) 00 00 f7 17 - time 00 80 - some kind of marker diff --git a/hid-tmff2.c b/hid-tmff2.c index 66c712b..b26185f 100644 --- a/hid-tmff2.c +++ b/hid-tmff2.c @@ -354,9 +354,11 @@ static int tmff_play(struct input_dev *dev, void *data, ep = &usbif->cur_altsetting->endpoint[1]; - switch (effect->type) { + switch (effect->type) { case FF_CONSTANT: - x = tmff_scale_s8(effect->u.ramp.start_level, + // this only works with input_ff_create_memless, which clamps + // constant forces to s8 for some reason + x = tmff_scale_s8(effect->u.constant.level, ff_field->logical_minimum, ff_field->logical_maximum); -- cgit v1.3