From 95680ede70a6c4d292f469b630e3c986620fd16a Mon Sep 17 00:00:00 2001 From: "guangqing.chen" Date: Mon, 25 Jul 2022 18:13:26 +0800 Subject: fix state->old may be updated incorrectly --- hid-tmff2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hid-tmff2.c b/hid-tmff2.c index 12e8e25..24b663e 100644 --- a/hid-tmff2.c +++ b/hid-tmff2.c @@ -388,7 +388,7 @@ static int tmff2_upload(struct input_dev *dev, state->effect = *effect; if (old) { - if (test_bit(FF_EFFECT_QUEUE_UPDATE, &state->flags)) + if (!test_bit(FF_EFFECT_QUEUE_UPDATE, &state->flags)) state->old = *old; __set_bit(FF_EFFECT_QUEUE_UPDATE, &state->flags); -- cgit v1.3